Minor code cleanups to decompress interceptor#4754
Merged
mcollina merged 1 commit intonodejs:mainfrom Jan 24, 2026
Merged
Conversation
* Do not save the pipeline stream anywhere. It is never referenced. * Consistently return `super.onResponseStart()` from the overridden `onResponseStart()`, instead of only doing so 2/3 times. These should not impact functionality.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4754 +/- ##
==========================================
- Coverage 93.22% 93.22% -0.01%
==========================================
Files 109 109
Lines 34024 34021 -3
==========================================
- Hits 31720 31716 -4
- Misses 2304 2305 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
reviewed
Jan 23, 2026
Member
metcoder95
left a comment
metcoder95
left a comment
There was a problem hiding this comment.
lgtm
Failures seems unrelated
metcoder95
approved these changes
Jan 23, 2026
Merged
slagiewka
pushed a commit
to slagiewka/undici
that referenced
this pull request
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
super.onResponseStart()from the overriddenonResponseStart(), instead of only doing so 2/3 times.These should not impact functionality. I will close this PR if it somehow causes test failures. (I guess removing the pipeline stream GC rooting could theoretically cause issues.)
This relates to...
No open issues, I just had to create a copy of this file in jsdom and got some interesting lint errors I thought you might appreciate getting fixed.
Rationale
These seem like bugs, albeit low-impact ones.
Changes
See commit message / top of PR description
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status